Fix race condition in task deploy #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
seebi
added a commit
that referenced
this pull request
Nov 16, 2023
* Revert "Revert "add example custom icon"" This reverts commit c5368e7. * use 4.2.0 and allow-prereleases * adjust dependencies * forward plugin base to 4.3.0 (cmem-cmempy >= 23.3) * avoid safety issue 62044 for pip less than 23.3 * fix race condition in task deploy (#19) * Execute clean and prepare sequencially in the deploy task * restructure deps --------- Co-authored-by: Sebastian Tramp <[email protected]> * change log * use poetry-dynamic-versioning option bump=true * pylint test folder as well * add target-version = "py311" to black * integrate ruff (removing bandit, flake8, black and pylint) * update README * ruff: ignore EM* * remove pylint gitlab job * remove PD rules * integrate pytest-dotenv * update README * fix missing check for poetry versioning plugin on build task --------- Co-authored-by: Natanael Arndt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing
task deploycan end up in a race condition, that thedistfolder is recursively deleted while it is recreated, which ends up in a failure as can be seen below: